Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special case plural handling should be on the primary subtag #3343

Open
ImUrX opened this issue Sep 16, 2024 · 4 comments
Open

Special case plural handling should be on the primary subtag #3343

ImUrX opened this issue Sep 16, 2024 · 4 comments
Labels
bug P3 Default, possibly shipping in the following two quarters

Comments

@ImUrX
Copy link
Contributor

ImUrX commented Sep 16, 2024

Because of how #2780 got fixed, if someone makes a new language like es-419, it will again add plural for many and its the same for any other language.
I don't really understand why this implementation of the fix checks for specific language tags instead of checking if the primary language is the expected one if this is a bug.
I also cant find the original reason as they are kinda correct plural rules, what happens if I use fluent.js? Does it have somewhere hardcoded that es is just ['one', 'other']?

@ImUrX
Copy link
Contributor Author

ImUrX commented Sep 16, 2024

ah the fluent.js part gets fixed because other is default, makes sense haha

@mathjazz
Copy link
Collaborator

@eemeli ?

@eemeli
Copy link
Member

eemeli commented Sep 22, 2024

The check could indeed be on just the primary subtag (e.g. es for es-419). These special cases are included to 1) support some languages that are not included yet in the CLDR, and 2) not default to including the many case for millions in romance languages.

@ImUrX
Copy link
Contributor Author

ImUrX commented Sep 23, 2024

yeah i noticed the bug because I had both es-es and es-419 active and saw that they had different plural rules which didnt make sense

@mathjazz mathjazz added bug P3 Default, possibly shipping in the following two quarters labels Sep 23, 2024
@mathjazz mathjazz moved this from 🆕 Needs triage to 🔖 Ready in Pontoon Roadmap Sep 23, 2024
@mathjazz mathjazz changed the title special case plural handling breaks when adding new languages by hand Special case plural handling should be on the primary subtag Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P3 Default, possibly shipping in the following two quarters
Projects
Status: 🔖 Ready
Development

No branches or pull requests

3 participants