Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Fathom see into iframes #259

Open
erikrose opened this issue Jul 24, 2020 · 1 comment
Open

Make Fathom see into iframes #259

erikrose opened this issue Jul 24, 2020 · 1 comment

Comments

@erikrose
Copy link
Contributor

Fathom's input comes from querySelector calls. Those cannot penetrate into iframes of different origins due to the same-origin policy. See if we can get around that somehow, perhaps with privileged code. It would be useful for credit-card autofill.

We should be able to see into iframes of the same origin. Confirm this is the case.

@DimiDL
Copy link
Collaborator

DimiDL commented May 19, 2022

To make this issue more clear:

  • For cross-origin iframes, we can't see elements inside the cross-origin iframe due to same-origin-policy
  • For same-origin iframes, although we can see elements inside an iframe, querySelector doesn't search elements outside the document.

To support penetrate same-origin iframes, the solutions I can think of currently is either extending the querySelector call to include iframes, Ex, querySelector("iframe").contentDocument.querySelector(selector) or performing vectorization in every same-origin document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants