Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Mozilla guidelines v5.7 #194

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

janbrasna
Copy link

Updates to v5.7 from v5.0 (online) and v4.0 (offline), in both cases a breaking change with new cipher list key naming/nesting.

Closes #192 (+also fixes #167)

(This points explicitly to 5.7.json instead of latest.json symlink for better control over releases.)

  • Updates JSON parsing.
  • Populates old sigalg from data.
  • Doesn't fail on missing protocols (NB: e.g. TLSv1.3…) +changes wording around it.
  • Fails intermediate on short kex.
  • Updates errors to reflect kex size from data.
  • Only fails on cipher order for old where relevant.

This doesn't change ordering checks as that may need a separate tweaking (only updated wording to better match reality for now). Also can't really test or enforce modern as that's TLSv1.3-only now, effectively invisible to current cipherscan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparing to outdated JSON spec (v5.0) Turn off TLSv1 warning in intermediate and above
1 participant