Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protection panel: Subpanels / Design QA #23398

Open
topotropic opened this issue Nov 26, 2024 · 0 comments
Open

Protection panel: Subpanels / Design QA #23398

topotropic opened this issue Nov 26, 2024 · 0 comments
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected

Comments

@topotropic
Copy link

topotropic commented Nov 26, 2024 •
edited by data-sync-user
Loading

The subpanels (trackers, connection) diverge from how the new menu looks but should look and feel the same, please verify and re-use the menu styles:

  • font sizes look smaller in the protection panel
  • divider looks thicker in the protection panel
  • Icon colors should be icon/secondary
  • spacing in connection panel is too much

See also Figma

┆Issue is synchronized with this Jira Task
@topotropic topotropic added the Bug 🐞 This is a bug with existing functionality not behaving as expected label Nov 26, 2024
petruSt24 added a commit to petruSt24/firefox-ios that referenced this issue Nov 26, 2024
@petruSt24
Bugfix FXIOS-10706 Protection panel: Subpanels / Design QA (mozilla-m…
b797dfa 
…obile#23398)
@petruSt24 petruSt24 mentioned this issue Nov 26, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@topotropic