Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi platform builds #124

Merged
merged 11 commits into from
Nov 15, 2023
Merged

Add support for multi platform builds #124

merged 11 commits into from
Nov 15, 2023

Conversation

brpaz
Copy link
Contributor

@brpaz brpaz commented Jul 30, 2023

Context

ARM-based platforms are getting more and more popular, and most well know projects and helm charts already support ARM architectures. (Ex: Prometheus, Grafana, Postgres, Cert Manager, etc). The only thing that I need in my Kubernetes cluster that was missing support for ARM was this operator.

This PR aims to fix that. Closes #123

Changes

  • Dockerfile - Add support for multi-platform builds following recommendations from this and this. Also refactored a bit the Dockerfile with cache support, which is important to optimize the build time, when building for multiple platforms.
  • GitHub Actions - Refactored the release workflow to leverage, official docker GitHub actions, which makes building images for multi-platform easier. Reference: https://docs.docker.com/build/ci/github-actions/multi-platform/

@brpaz brpaz mentioned this pull request Jul 30, 2023
Copy link
Member

@hitman99 hitman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thank you for the contribution

build/Dockerfile.dist Show resolved Hide resolved
@hitman99 hitman99 merged commit 76f09b1 into movetokube:master Nov 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARM support
3 participants