Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide clang-tidy feedback inline on pull requests #1619

Open
EzraBrooks opened this issue Oct 17, 2022 · 0 comments
Open

Provide clang-tidy feedback inline on pull requests #1619

EzraBrooks opened this issue Oct 17, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@EzraBrooks
Copy link
Member

Is your feature request related to a problem? Please describe.

Digging through clang-tidy output in CI is inconvenient, and the GitHub Checks API allows Checks to annotate PRs with feedback so you don't have to dig.

Describe the solution you'd like

Use clang-tidy-action, or similar, to annotate clang-tidy violations onto PR diffs. Here's an example of what it looks like:

Screen Shot 2022-10-17 at 2 54 00 PM

Describe alternatives you've considered

There are third-party tools for visualizing these things, but having it directly in GitHub is much nicer.

Additional context

Exporting the clang-tidy fixes file from industrial_ci is not currently supported as far as I can tell, see ros-industrial/industrial_ci#796.

@tylerjw asked me to create this issue so he wouldn't forget my suggestion 😄

@EzraBrooks EzraBrooks added the enhancement New feature or request label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant