Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console error on world load, possibly pertaining to renderSidebarTab and related to the innerHTML property #116

Open
IHaveThatPower opened this issue Feb 10, 2024 · 3 comments

Comments

@IHaveThatPower
Copy link

Following console error occurs on world load:

caught (in promise) TypeError: undefined. Cannot set properties of null (setting 'innerHTML')
[Detected 1 package: module-credits]
    at Object.renderSidebarTab [as fn] (bundle.min.mjs:1:108436)

Seems to be referencing this:

i[0].querySelector(isNewerVersion(game.version, "11") ? "#game-details li.system span.system-info" : "#game-details li.system span").innerHTML = ...
@BladeFireLight
Copy link

image
also seeing this error

@ctbritt
Copy link

ctbritt commented Aug 30, 2024

also seeing this error. Doesn't seme to hurt anything tho.

@IHaveThatPower
Copy link
Author

Created a pull request that fixes this in #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants