This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Feature/bn forward callback function #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When publishing a message to rabbitmq via amqp the options object was dropped in amqp_ascolatore. The options object is now forwarded to the exchange.
…change [BUGFIX] Forward amqp options when publish to exchange
Adding exchangeOptions object (next to exchange in configuration) that enables the user to declare the exchange as durable.
[FEATURE] Add exchangeOptions
When publishing a message to rabbitmq via amqp the callback function was defered independent of the result of exchange publish process. Now the callback is called by this, enhancing reliability of "done" state.
mcollina
reviewed
Feb 26, 2018
| @@ -8,6 +8,12 @@ var AbstractAscoltatore = require('./abstract_ascoltatore'); | |||
| var steed = require("steed")(); | |||
| var SubsCounter = require("./subs_counter"); | |||
| var debug = require("debug")("ascoltatori:amqp"); | |||
| var _ = require('lodash'); | |||
There was a problem hiding this comment.
can you please avoid adding lodash as a dependency?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.