Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hf ingestion #483

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

XiaohanZhangCMU
Copy link
Member

Description of changes:

Add a ingestion helper utility for Huggingface datasets downloading.
Building on snapshot_download, some improvements include

  • Enable resume = True. retry when bad network happens
  • Disable progress_bar to prevent browser/terminal crash
  • Add a monitor to print out file stats every 15 seconds

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

return output


def download_hf_dataset(local_cache_directory: str,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this method support downloading all the popular HF Generative AI datasets?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a great pr to see if we could abuse the new fsspec hf fsspec system to start accessing files. we would just need to use fsspec open and the related ls shims to navigate through the directories.

Comment on lines +41 to +42
if not os.path.exists(directory):
os.makedirs(directory)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if not os.path.exists(directory):
os.makedirs(directory)
os.makedirs(directory, exist_ok=True)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants