-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major update: right axis / data labels / combo charts / jQuery deps removed / animation / ... #776
Open
pierresh
wants to merge
161
commits into
morrisjs:master
Choose a base branch
from
pierresh:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to clarify updates done by further changes in coffee files
See original bug here morrisjs#534
See original problem here morrisjs#534
Original problem described here: morrisjs#571
This is to display the red before the second blue
Before animation did not start from the axis, but only from the position of the rectangle
Also add check for ymax2 and ymin2
Inspired from morrisjs#464
Inspired from morrisjs#344 morrisjs#221
Fix #16 Inspired from morrisjs#533
NPM import based on this file: #4 Types definition based on: mledour/angular-morris-js#13
Add element and data Unify the type for Line chart and Bar bar
- add missing types - fix path to /dist - remove trailing white spaces
This works with a new key "ratio", to be between 0 and 1, that would adjust the length of the segment If ratio is not defined, it would be set to 1 automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All along the year 2018 I have updated Morris.js with many new features, including:
The result is very satisfying and I suppose it would much better that these improvements get merged into the main repo so that much more people could benefit from it.