Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling command line arguments #1

Open
morgant opened this issue Oct 18, 2023 · 0 comments
Open

Improve handling command line arguments #1

morgant opened this issue Oct 18, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@morgant
Copy link
Owner

morgant commented Oct 18, 2023

This was a quick hack, on my part, so currently the one -s option has very rudimentary handling and there's zero input validation. Ideally, there would be validation requiring:

  • Require one or more arguments
  • Validate that the resulting file doesn't already exist (ffmpeg will prompt to overwrite, but since we're using two processes with pipes, I'm not sure if that works)
  • Easily support future options (beyond -s), especially:
    • -h for help
    • -q for quiet
    • -v for verbose
    • Maybe specifying FPS or container file type?
  • Display help if invalid options or number of arguments are provided
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant