From 3586550aecbf34fdbd048b289286f67929c3d602 Mon Sep 17 00:00:00 2001 From: Martin Duke Date: Tue, 3 Dec 2024 19:39:41 +0000 Subject: [PATCH 1/7] Define Object ID of EndOfTrack --- draft-ietf-moq-transport.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/draft-ietf-moq-transport.md b/draft-ietf-moq-transport.md index fd70e3e5..995a2eed 100644 --- a/draft-ietf-moq-transport.md +++ b/draft-ietf-moq-transport.md @@ -2121,9 +2121,7 @@ are beyond the end of a group or track. * 0x4 := Indicates end of Track and Group. GroupID is one greater than the largest group produced in this track and the ObjectId is - one greater than the largest object produced in that - group. This is sent right after the last object in the - track. This SHOULD be cached. + zero. Any other value SHOULD be treated as a protocol error and terminate the session with a Protocol Violation ({{session-termination}}). From 06b2aee19fe561237b499fc91da112cb9255fefb Mon Sep 17 00:00:00 2001 From: Martin Duke Date: Tue, 3 Dec 2024 19:42:53 +0000 Subject: [PATCH 2/7] What if it's wrong? --- draft-ietf-moq-transport.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/draft-ietf-moq-transport.md b/draft-ietf-moq-transport.md index 995a2eed..58f9e3c4 100644 --- a/draft-ietf-moq-transport.md +++ b/draft-ietf-moq-transport.md @@ -2121,7 +2121,9 @@ are beyond the end of a group or track. * 0x4 := Indicates end of Track and Group. GroupID is one greater than the largest group produced in this track and the ObjectId is - zero. + zero. An object with this status that has a Group ID less than or + equal to any other Group ID, or an Object ID other than zero, is + a protocol error, and the receiver MUST terminate the session. Any other value SHOULD be treated as a protocol error and terminate the session with a Protocol Violation ({{session-termination}}). From b6ad7d77881808c897645948c28e9d53fff317c7 Mon Sep 17 00:00:00 2001 From: Martin Duke Date: Tue, 3 Dec 2024 20:54:04 +0000 Subject: [PATCH 3/7] whitespace --- draft-ietf-moq-transport.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/draft-ietf-moq-transport.md b/draft-ietf-moq-transport.md index 58f9e3c4..a6379c31 100644 --- a/draft-ietf-moq-transport.md +++ b/draft-ietf-moq-transport.md @@ -2123,7 +2123,7 @@ are beyond the end of a group or track. the largest group produced in this track and the ObjectId is zero. An object with this status that has a Group ID less than or equal to any other Group ID, or an Object ID other than zero, is - a protocol error, and the receiver MUST terminate the session. + a protocol error, and the receiver MUST terminate the session. Any other value SHOULD be treated as a protocol error and terminate the session with a Protocol Violation ({{session-termination}}). From 0c2dca7864b76c448906262c84cdc185f848a35c Mon Sep 17 00:00:00 2001 From: Martin Duke Date: Wed, 4 Dec 2024 21:08:24 +0000 Subject: [PATCH 4/7] Alan's comment --- draft-ietf-moq-transport.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/draft-ietf-moq-transport.md b/draft-ietf-moq-transport.md index a6379c31..030b1aed 100644 --- a/draft-ietf-moq-transport.md +++ b/draft-ietf-moq-transport.md @@ -2119,11 +2119,11 @@ are beyond the end of a group or track. in this Group. This SHOULD be cached. A publisher MAY use an end of Group object to signal the end of all open Subgroups in a Group. -* 0x4 := Indicates end of Track and Group. GroupID is one greater than - the largest group produced in this track and the ObjectId is - zero. An object with this status that has a Group ID less than or - equal to any other Group ID, or an Object ID other than zero, is - a protocol error, and the receiver MUST terminate the session. +* 0x4 := Indicates end of Track. GroupID is one greater than the largest group + produced in this track and the ObjectId is zero. An object with this + status that has a Group ID less than or equal to any other Group ID, or + an Object ID other than zero, is a protocol error, and the receiver + MUST terminate the session. Any other value SHOULD be treated as a protocol error and terminate the session with a Protocol Violation ({{session-termination}}). From f0608f4d70315d3a763dc006146254ab8c0c4a90 Mon Sep 17 00:00:00 2001 From: ianswett Date: Wed, 11 Dec 2024 12:20:39 -0500 Subject: [PATCH 5/7] Update draft-ietf-moq-transport.md --- draft-ietf-moq-transport.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/draft-ietf-moq-transport.md b/draft-ietf-moq-transport.md index 030b1aed..87d17b68 100644 --- a/draft-ietf-moq-transport.md +++ b/draft-ietf-moq-transport.md @@ -2123,7 +2123,7 @@ are beyond the end of a group or track. produced in this track and the ObjectId is zero. An object with this status that has a Group ID less than or equal to any other Group ID, or an Object ID other than zero, is a protocol error, and the receiver - MUST terminate the session. + MUST terminate the session. This SHOULD be cached. Any other value SHOULD be treated as a protocol error and terminate the session with a Protocol Violation ({{session-termination}}). From 6000803b8e7e6e7a1f2e3f73c30587229788df6d Mon Sep 17 00:00:00 2001 From: afrind Date: Mon, 16 Dec 2024 13:53:34 -0800 Subject: [PATCH 6/7] Add back end-of-track-and-group --- draft-ietf-moq-transport.md | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/draft-ietf-moq-transport.md b/draft-ietf-moq-transport.md index 87d17b68..57a78902 100644 --- a/draft-ietf-moq-transport.md +++ b/draft-ietf-moq-transport.md @@ -2119,7 +2119,14 @@ are beyond the end of a group or track. in this Group. This SHOULD be cached. A publisher MAY use an end of Group object to signal the end of all open Subgroups in a Group. -* 0x4 := Indicates end of Track. GroupID is one greater than the largest group +* 0x4 := Indicates end of Track and Group. GroupID is the largest group produced + in this track and the ObjectId is one greater than the largest object + produced in this track. An object with this status that has a Group ID + less than any other Group ID, or an Object ID less than or equal to the + largest in the group, is a protocol error, and the receiver MUST + terminate the session. This SHOULD be cached. + +* 0x5 := Indicates end of Track. GroupID is one greater than the largest group produced in this track and the ObjectId is zero. An object with this status that has a Group ID less than or equal to any other Group ID, or an Object ID other than zero, is a protocol error, and the receiver From 5cfed4ab169251ee37f1d48f2d3f01c22bee0198 Mon Sep 17 00:00:00 2001 From: afrind Date: Mon, 16 Dec 2024 13:54:30 -0800 Subject: [PATCH 7/7] that group --- draft-ietf-moq-transport.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/draft-ietf-moq-transport.md b/draft-ietf-moq-transport.md index 57a78902..0202d8be 100644 --- a/draft-ietf-moq-transport.md +++ b/draft-ietf-moq-transport.md @@ -2121,7 +2121,7 @@ are beyond the end of a group or track. * 0x4 := Indicates end of Track and Group. GroupID is the largest group produced in this track and the ObjectId is one greater than the largest object - produced in this track. An object with this status that has a Group ID + produced in that group. An object with this status that has a Group ID less than any other Group ID, or an Object ID less than or equal to the largest in the group, is a protocol error, and the receiver MUST terminate the session. This SHOULD be cached.