Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If users are allowed to connect on any network, warn distributor about risk of lost funds #172

Open
mds1 opened this issue Nov 1, 2021 · 0 comments

Comments

@mds1
Copy link

mds1 commented Nov 1, 2021

If users are allowed to connect on any network, users with contract wallets on one network are not guaranteed to be able to receive funds sent on other networks.

For example, Argent currently only deploys their user's contract wallets on mainnet. If users connect their Argent wallets to mainnet but the distributor sends funds on Polygon, funds sent to those Argent users will be lost.

Potential solutions:

  1. Require users to connect to a certain network
  2. Detect if a user is connected with Argent (or other contract wallets with similar issues), disconnect them, and prompt them to connect with a different wallet
  3. Warn distributor about this and accept the risk
@codenamejason codenamejason added bug Something isn't working user-security front-end and removed bug Something isn't working labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@codenamejason @mds1 and others