Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: MSSQL support #92

Open
dionysius opened this issue Mar 11, 2021 · 2 comments · May be fixed by #302
Open

Request: MSSQL support #92

dionysius opened this issue Mar 11, 2021 · 2 comments · May be fixed by #302
Labels
enhancement New feature or request

Comments

@dionysius
Copy link
Contributor

dionysius commented Mar 11, 2021 •
edited
Loading

Moodle supports more databases than what moodle-plugin-ci currently offers. In studentquiz/moodle-mod_studentquiz#314 we got the first issue for MSSQL.

We would like to support MSSQL, but to confidently do that, we need to ensure that the testing toolchain can test against it as well.

Is moodlehq willing to add support for MSSQL?

If we are lucky, we only need to document how travis or github actions files need to be written.
@dionysius dionysius mentioned this issue Mar 11, 2021
Closed
@stronk7 stronk7 added the enhancement New feature or request label Mar 25, 2021
@kabalin
Copy link
Member

kabalin commented Apr 12, 2021 •
edited
Loading

Hi @dionysius, I think it would be great to include MSSQL support. I think this will need:

  • New DB type support changes, i.e. --db-type option description, db resolver code changes, new db class, tests.
  • Docs explaining how to use it in test (including changes gha.dist.yml and travis.dist.yml)
  • Some example showing this works. May be expand self-test CI and add a new stage containing matrix of all supported DBs for Moodle installation step test only (i.e. to make it quick, just to ensure that chosen DB works).

PR with above changes will be very appreciated :)

@dionysius dionysius mentioned this issue Aug 2, 2021
Open
@jpahullo jpahullo mentioned this issue Aug 10, 2021
Closed
@dionysius
Copy link
Contributor Author

There has been a lot of discussion and ideas in the freshly linked issue #128 for oracle DB. I'm not familiar with github actions, but if they support docker images, we could try to use the mssql images provided by microsoft: https://hub.docker.com/_/microsoft-mssql-server

@ewallah ewallah mentioned this issue Feb 14, 2022
Closed
@justusdieckmann justusdieckmann linked a pull request May 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for MSSQL justusdieckmann/moodle-plugin-ci
3 participants
@stronk7 @kabalin @dionysius