Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Change label of version selector #479

Open
andrewnicols opened this issue Dec 12, 2022 · 3 comments
Open

[chore] Change label of version selector #479

andrewnicols opened this issue Dec 12, 2022 · 3 comments
Labels
help wanted Extra attention is needed repo

Comments

@andrewnicols
Copy link
Member

What do we need to do?

A suggestion from Eloy re version dropdown selector:

Does the drop down need some label? Maybe not, but right now it looks like (to me, this is a 100% subjective feeling) it's floating in the middle of nowhere.

@andrewnicols andrewnicols added help wanted Extra attention is needed repo labels Dec 12, 2022
@andrewnicols andrewnicols changed the title [chore] Change label of verison selector [chore] Change label of version selector Dec 12, 2022
@andrewnicols
Copy link
Member Author

I guess the question here is, what do you think the label should be?

@stronk7
Copy link
Member

stronk7 commented Dec 12, 2022

Heh,

really I don't know, I'm afraid not being useful here. As I originally commented, this was 100% a first-impression personal feeling. Maybe some "Current version: " or "You are viewing". Don't know, honestly. Maybe the proposal is worse than the current status.

It may have sense if we make the whole element non-clickable (@ #477), maybe (to avoid the un-desired jumps to "base" page). The the text would just hover and done.

Honestly, I'm not 100% sure, just imagining potential alternatives.

Ciao :-)

@andrewnicols
Copy link
Member Author

Ahh right. I honestly hadn't noticed that you even could click on the menu for the dropdown.

For mobile, it shows as "Versions" as an unclickable link. I can make that happen, or something similar, but it's not a simple change.

I'm inclined to raise a PR against Docusaurus to do it in a different (better?) way through config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed repo
Projects
None yet
Development

No branches or pull requests

3 participants