We love pull requests from everyone.
Fork, then clone the repo:
$ git clone [email protected]:your-username/Montreal.rb.git
Set up your machine (read the appropriate README section):
$ bin/setup
Make sure the tests pass:
$ bin/rspec
Make your change. Add tests for your change. Make the tests pass:
$ bin/rspec
Push to your fork and submit a pull request.
At this point you're waiting on us. We like to at least comment on pull requests within three business days (and, typically, one business day). We may suggest some changes or improvements or alternatives.
Some things that will increase the chance that your pull request is accepted:
- Write tests.
- Follow our project's standards.
- Write a good commit message.
This codebase is using houndci.com a hosted service that reviews GitHub pull requests for Ruby, CoffeeScript, and SCSS style guide violations.
For more information about the different style guides we try to enforce, please check the list below.
- Ruby
- Rails
- Testing
- ERB Templating
- Bootstrap 3 - HTML, CSS, and JS Framework
- Sass - CSS Preprocessor
- CoffeeScript
- Markdown
- Interface text should be written subjectively instead of objectively. It should be the Montrealrb.com core team addressing a person. It should be written in present time and never use past tense (has been/was). For example instead of "prohibited this user from being saved due to the following errors:" the text should be "sorry, we could not create your account because:". Also these excellent writing guidelines.