Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ColorGains Setting #10

Open
monkeymademe opened this issue Feb 5, 2024 · 2 comments
Open

Add ColorGains Setting #10

monkeymademe opened this issue Feb 5, 2024 · 2 comments

Comments

@monkeymademe
Copy link
Owner

monkeymademe commented Feb 5, 2024

Worth noting this setting should disable AWB... Question is do I need to reflect this in the UI (likely)

@monkeymademe
Copy link
Owner Author

ColourGains might need more code than I thought. Default values are as always min, max and default but they are a single float number. Picamera2 (or rather libcamera at the end) expects 2 floating point numbers for Red and Blue.

So a decision needs to be made. Do I collect the values for the ColourGains from the feed and use them as default. Zero the floating point numbers or not apply any ColourGains and allow the user to set them (basically exclude them from the default values)

@TimPGamer
Copy link
Contributor

TimPGamer commented Apr 20, 2024

yo that would be nice for people using night vision cameras, to correct some of the redness when using at daytime. The infrared light, that makes its way into the camera makes the image quite a bit red, so I would appreciate it if you could implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants