From 048e51b59a68f4bbf3de138c78ac7526ba8bb1a7 Mon Sep 17 00:00:00 2001
From: gagik <me@gagik.co>
Date: Fri, 20 Dec 2024 18:06:15 +0100
Subject: [PATCH] use enums

---
 src/participant/participant.ts           | 77 +++++++++++++-----------
 src/participant/participantErrorTypes.ts |  6 ++
 src/telemetry/telemetryService.ts        |  2 +-
 3 files changed, 49 insertions(+), 36 deletions(-)

diff --git a/src/participant/participant.ts b/src/participant/participant.ts
index de751bab0..c105a3ae1 100644
--- a/src/participant/participant.ts
+++ b/src/participant/participant.ts
@@ -45,7 +45,10 @@ import { processStreamWithIdentifiers } from './streamParsing';
 import type { PromptIntent } from './prompts/intent';
 import { isPlayground, getSelectedText, getAllText } from '../utils/playground';
 import type { DataService } from 'mongodb-data-service';
-import { ParticipantErrorTypes } from './participantErrorTypes';
+import {
+  ExportToPlaygroundFailure,
+  ParticipantErrorTypes,
+} from './participantErrorTypes';
 import type PlaygroundResultProvider from '../editors/playgroundResultProvider';
 import { isExportToLanguageResult } from '../types/playgroundType';
 import { PromptHistory } from './prompts/promptHistory';
@@ -1792,7 +1795,9 @@ export default class ParticipantController {
     const codeToExport = getSelectedText() || getAllText();
 
     try {
-      const content = await vscode.window.withProgress(
+      const contentOrFailure = await vscode.window.withProgress<
+        string | ExportToPlaygroundFailure | null
+      >(
         {
           location: vscode.ProgressLocation.Notification,
           title: 'Exporting code to a playground...',
@@ -1805,15 +1810,7 @@ export default class ParticipantController {
               request: { prompt: codeToExport },
             });
           } catch (error) {
-            void vscode.window.showErrorMessage(
-              'Failed to generate a MongoDB Playground. Please ensure your code block contains a MongoDB query.'
-            );
-
-            this._telemetryService.trackExportToPlaygroundFailed({
-              input_length: codeToExport?.length,
-              details: 'modelInput',
-            });
-            return null;
+            return ExportToPlaygroundFailure.STREAM_CHAT_RESPONSE;
           }
 
           const result = await Promise.race([
@@ -1821,53 +1818,63 @@ export default class ParticipantController {
               modelInput,
               token,
             }),
-            new Promise<'cancelled'>((resolve) =>
+            new Promise<ExportToPlaygroundFailure>((resolve) =>
               token.onCancellationRequested(() => {
                 log.info('The export to a playground operation was canceled.');
-                resolve('cancelled');
+                resolve(ExportToPlaygroundFailure.CANCELLED);
               })
             ),
           ]);
 
-          if (result === 'cancelled') {
-            return null;
+          if (result === ExportToPlaygroundFailure.CANCELLED) {
+            return ExportToPlaygroundFailure.CANCELLED;
           }
 
           if (!result || result?.includes("Sorry, I can't assist with that.")) {
-            void vscode.window.showErrorMessage(
-              'Failed to generate a MongoDB Playground. Please ensure your code block contains a MongoDB query.'
-            );
-
-            this._telemetryService.trackExportToPlaygroundFailed({
-              input_length: codeToExport?.length,
-              details: 'streamChatResponseWithExportToLanguage',
-            });
-
-            return null;
+            return ExportToPlaygroundFailure.STREAM_CHAT_RESPONSE;
           }
 
           return result;
         }
       );
 
-      if (!content) {
+      if (
+        !contentOrFailure ||
+        contentOrFailure === ExportToPlaygroundFailure.CANCELLED
+      ) {
         return true;
       }
 
-      try {
-        await vscode.commands.executeCommand(
-          EXTENSION_COMMANDS.OPEN_PARTICIPANT_CODE_IN_PLAYGROUND,
-          {
-            runnableContent: content,
-          }
+      if (
+        Object.values(ExportToPlaygroundFailure).includes(
+          contentOrFailure as ExportToPlaygroundFailure
+        )
+      ) {
+        void vscode.window.showErrorMessage(
+          'Failed to generate a MongoDB Playground. Please ensure your code block contains a MongoDB query.'
+        );
+
+        // Content in this case is already equal to the failureType; this is just to make it explicit
+        // and avoid accidentally sending actual contents of the message.
+        const failureType = Object.values(ExportToPlaygroundFailure).find(
+          (value) => value === contentOrFailure
         );
-      } catch (error) {
         this._telemetryService.trackExportToPlaygroundFailed({
-          input_length: content.length,
-          details: 'executeCommand',
+          input_length: codeToExport?.length,
+
+          details: failureType,
         });
+        return false;
       }
 
+      const content = contentOrFailure;
+      await vscode.commands.executeCommand(
+        EXTENSION_COMMANDS.OPEN_PARTICIPANT_CODE_IN_PLAYGROUND,
+        {
+          runnableContent: content,
+        }
+      );
+
       return true;
     } catch (error) {
       const message = formatError(error).message;
diff --git a/src/participant/participantErrorTypes.ts b/src/participant/participantErrorTypes.ts
index 1b2a6ce83..208c31bd8 100644
--- a/src/participant/participantErrorTypes.ts
+++ b/src/participant/participantErrorTypes.ts
@@ -5,3 +5,9 @@ export enum ParticipantErrorTypes {
   OTHER = 'Other',
   DOCS_CHATBOT_API = 'Docs Chatbot API Issue',
 }
+
+export enum ExportToPlaygroundFailure {
+  CANCELLED = 'cancelled',
+  MODEL_INPUT = 'modelInput',
+  STREAM_CHAT_RESPONSE = 'streamChatResponseWithExportToLanguage',
+}
diff --git a/src/telemetry/telemetryService.ts b/src/telemetry/telemetryService.ts
index 4d5c0ff08..d0e53defa 100644
--- a/src/telemetry/telemetryService.ts
+++ b/src/telemetry/telemetryService.ts
@@ -56,7 +56,7 @@ type DocumentEditedTelemetryEventProperties = {
 
 type ExportToPlaygroundFailedEventProperties = {
   input_length: number | undefined;
-  details: string;
+  details?: string;
 };
 
 type PlaygroundExportedToLanguageTelemetryEventProperties = {