Skip to content
This repository has been archived by the owner on Mar 9, 2024. It is now read-only.

Wrap/Map Addressbook struct/classes #6

Open
ehanoc opened this issue Mar 8, 2018 · 0 comments
Open

Wrap/Map Addressbook struct/classes #6

ehanoc opened this issue Mar 8, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ehanoc
Copy link

ehanoc commented Mar 8, 2018

  • Wrap AddressBook usage to corresponding wallet/api/python/*.cpp files prefixed by "Py" that use shared pointers instead of raw pointers.

  • Add these new mapped classes to pywallet_api modules at wallet/api/python/pywallet_api.cpp

  • wallet/api/wallet2_api.h as reference

For more info on why this is needed read : http://pybind11.readthedocs.io/en/stable/advanced/smart_ptrs.html#std-shared-ptr

@ehanoc ehanoc added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 8, 2018
@ehanoc ehanoc added this to the 0.0.1.pywallet_api milestone Mar 8, 2018
@ehanoc ehanoc self-assigned this Mar 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant