Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] ListItemAvatar - Be able to provide all Avatar props #2008

Open
talkor opened this issue Mar 11, 2024 · 7 comments · May be fixed by #2560
Open

[Feat] ListItemAvatar - Be able to provide all Avatar props #2008

talkor opened this issue Mar 11, 2024 · 7 comments · May be fixed by #2560
Assignees
@naorpeled
Labels
contribution welcome feature hacktoberfest

Comments

@talkor
Copy link
Member

talkor commented Mar 11, 2024 •
edited
Loading

Currently ListItemAvatar component can get only a few props (e.g. src, type, size). It should be able to get all Avatar props (AvatarProps). It can be achieved by extending the ListItemAvatarProps to AvatarProps and spreading the avatar props into the component.

Monday ticket (internal): https://monday.monday.com/boards/3532714909/pulses/5741029337
@MohammedHaris96
Copy link
Contributor

Hey!! @talkor is anyone working on this?

@talkor
Copy link
Member Author

talkor commented Mar 20, 2024

Hey!! @talkor is anyone working on this?

Not that I know of, if you want go ahead! Thanks!

@MohammedHaris96
Copy link
Contributor

Hey!! @talkor is anyone working on this?

Not that I know of, if you want go ahead! Thanks!

Sure I'll take that up. Can you please assign it to me?

@talkor
Copy link
Member Author

talkor commented Aug 26, 2024

@MohammedHaris96 removing you as a assignee to give other the option to take this task, but if you still want feel free to take it anyway :) Thanks

@naorpeled
Copy link
Contributor

Hey @talkor,
would love to help with this,
may I be assigned to this issue? 🙏

Thanks!

@talkor
Copy link
Member Author

talkor commented Oct 13, 2024

We are really happy to see this engagement in the recent issues, but there's no need to assign specific people, simply open a PP :) Thanks!

@naorpeled
Copy link
Contributor

We are really happy to see this engagement in the recent issues, but there's no need to assign specific people, simply open a PP :) Thanks!

Sababa, will do :)

@naorpeled naorpeled linked a pull request Oct 24, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naorpeled naorpeled

Labels
contribution welcome feature hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ListItemAvatar): support Avatar props naorpeled/monday-ui-react-core
3 participants
@naorpeled @talkor @MohammedHaris96