feature: add support for multi region param

mondaycom · May 27, 2024 · 89d2e2d · 89d2e2d
1 parent f5bd864
commit 89d2e2d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/src/commands/app/deploy.ts b/src/commands/app/deploy.ts
@@ -60,21 +60,20 @@ export default class AppDeploy extends AuthenticatedCommand {
   public async run(): Promise<void> {
     try {
       const { flags } = await this.parse(AppDeploy);
-      const { directoryPath, appId, appVersionId, force } = flags;
+      const { directoryPath, force, appId } = flags;
       const region = getRegionFromString(flags?.region);
       const manifestFileDir = directoryPath || getCurrentWorkingDirectory();
       const manifestFileData = readManifestFile(manifestFileDir);
       flags.appId = appId || manifestFileData.app.id;
 
-      flags.appVersionId = await this.getAppVersionId(appVersionId, appId, force);
-
-      this.preparePrintCommand(this, { appVersionId: appVersionId, directoryPath: manifestFileData });
+      flags.appVersionId = await this.getAppVersionId(flags.appVersionId, flags.appId, force);
+      this.preparePrintCommand(this, { appVersionId: flags.appVersionId, directoryPath: manifestFileData });
 
       const { cdn, server } = manifestFileData.app?.hosting || {};
       if (cdn && cdn.type === ManifestHostingType.Upload) {
         logger.info('Deploying files to cdn...');
         await getTasksForClientSide(
-          Number(appVersionId),
+          Number(flags.appVersionId),
           getManifestAssetPath(manifestFileDir, cdn.path),
           region,
         ).run();
@@ -83,7 +82,7 @@ export default class AppDeploy extends AuthenticatedCommand {
       if (server && server.type === ManifestHostingType.Upload) {
         logger.info('Deploying server side files...');
         await getTasksForServerSide(
-          Number(appVersionId),
+          Number(flags.appVersionId),
           getManifestAssetPath(manifestFileDir, server.path),
           region,
         ).run();

diff --git a/src/services/share/deploy.ts b/src/services/share/deploy.ts
@@ -12,6 +12,7 @@ import { PushCommandTasksContext } from 'types/commands/push';
 import { Region } from 'types/general/region';
 
 export const getTasksForClientSide = (appVersionId: number, directoryPath?: string, region?: Region) => {
+  const ctx = { appVersionId, directoryPath, region };
   return new Listr<PushCommandTasksContext>(
     [
       { title: 'Build asset to deploy', task: buildClientZip },
@@ -21,12 +22,13 @@ export const getTasksForClientSide = (appVersionId: number, directoryPath?: stri
       },
     ],
     {
-      ctx: { appVersionId, directoryPath, region },
+      ctx,
     },
   );
 };
 
 export const getTasksForServerSide = (appVersionId: number, directoryPath?: string, region?: Region) => {
+  const ctx = { appVersionId, directoryPath, region };
   return new Listr<PushCommandTasksContext>(
     [
       { title: 'Build asset to deploy', task: buildAssetToDeployTask },
@@ -46,6 +48,6 @@ export const getTasksForServerSide = (appVersionId: number, directoryPath?: stri
         enabled: ctx => Boolean(ctx.showHandleDeploymentTask),
       },
     ],
-    { ctx: { appVersionId, directoryPath, region } },
+    { ctx },
   );
 };