Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation 230515 #169

Merged
merged 4 commits into from
May 17, 2024
Merged

Update documentation 230515 #169

merged 4 commits into from
May 17, 2024

Conversation

sabrinatoro
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@katiermullen katiermullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit difficult for me to assess the format, but the content so far looks good. I only found one thing you may want to change.

Thank you for doing this!!!!


One can refer to the same breed by multiple names, including names in different languages (e.g. ‘Artois Hound’ and ‘Chien d’Artois’ refer to the same breed). In addition, the same name is often used to refer to different breeds, of different species. For example, “Tibetan” is the name for a breed of cattle, sheep, chicken, pig, goat, etc. However, a VBO term label must be unique, i.e. multiple terms cannot have the same label, even if their names are the same. In this document, we explain how VBO term labels were created to ensure uniqueness and uniformity.

Breeds from different species often share the same name. For example, “Tibetan” is the name for a breed of cattle, sheep, chicken, pig, goat, etc. In addition, some breeds are commonly called by names that can represent other types of entities. For example “Cyprus” is used to refer to breeds of cattle, cat, etc., but also to the country “Cyprus”.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend perhaps leaving this out because it is repetitive: Breeds from different species often share the same name. For example, “Tibetan” is the name for a breed of cattle, sheep, chicken, pig, goat, etc. In addition,

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the proposed changes

Copy link
Collaborator

@katiermullen katiermullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more typo identified

docs/ontologymodeling/merge-obsolete.md Show resolved Hide resolved
@sabrinatoro
Copy link
Collaborator Author

@katiermullen this is ready for re-review when you have a moment. Thank you!

@katiermullen
Copy link
Collaborator

@sabrinatoro I reviewed your changes and I approve of them. Thank you for all of this work on the VBO documentation!

@sabrinatoro sabrinatoro merged commit 708c1e4 into master May 17, 2024
1 check passed
@sabrinatoro sabrinatoro deleted the 240515-doc branch May 17, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants