Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated VBO with new templates #115

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Conversation

sabrinatoro
Copy link
Collaborator

Note that #113 has been given weird errors and some components would not refresh even when using -B. This PR seems to be cleaner (assuming it passes the checks).

Note that #113 has been given weird errors and some components would not refresh even when using -B.
This PR seems to be cleaner (assuming it passes the checks).
the original row for these 3 terms was maintained instead of having been removed during the obsoletion process.
@sabrinatoro
Copy link
Collaborator Author

@katiermullen
I recreated the PR (the previous one had a lot of weird things going on), and it passed the checks.
I think everything looks good, but I would appreciate your taking another look.
Thank you!

@katiermullen
Copy link
Collaborator

@sabrinatoro Thank you for all of your work updating the components!

Small issues:

  • Swedish Briard has an extra space between breed name and (Dog) - fixed in spreadsheet.
  • Racking Horse (Horse) dcterms:source is not displayed as URIs. Is this due to the "/" at the end of the URIs?
  • Spotted Saddle Horse (Horse) same as above.

@sabrinatoro
Copy link
Collaborator Author

@katiermullen thank you for checking.
The issue about "Racking Horse (Horse)" and "Spotted Saddle Horse (Horse)" is because we didn't have the "SPLIT=|" in the column, so it was considered as one big web address. I updated and will update components.

Copy link
Collaborator

@katiermullen katiermullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sabrinatoro - Reviewed and approved for merging.

@sabrinatoro sabrinatoro merged commit 683c977 into master Sep 7, 2023
1 check passed
@sabrinatoro sabrinatoro deleted the 230906-updatespreadsheets branch September 7, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants