-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add import refresh to release SOP? #8423
Comments
EDIT: just to be clear this is not a big problem, all our tooling for accessing the ontology can handle this case. |
Do you mean running the import? It is on our to-do list for the Friday before the release. |
I thought so, but why do we have so many genes then that are not imported? |
I would have to dig deeper into this, but maybe it has to do with all the new non-human diseases that were added after the last import. That, plus the new terms we created during the curateathon (again, I would have to check) Question for you, @matentzn : are these going to update themselves when updating the import, or do we need to add them to a list to be added manually (as explained here)? If the latter, it might be why there are so many. |
they will update themselves i believe. Import refresh should perhaps be the last thing to do.. Maybe move to Monday evening? |
I believe these are a combination of curate-a-thon additions, non-human, and the previous refresh imports issue that is now resolved. When I tested the updates Nico added to the refresh imports all but ~2 "updated themselves". I'll need to get these into https://github.com/monarch-initiative/ncbi-gene/blob/main/src/ncbi_gene/transform.yaml.... and should create a ticket for this. Refreshing the imports is the last thing done on Week 3 of the MONDO SOP. |
We should try to avoid releasing Mondo with terms that have not been imported yet. If you look at the current release, you see at least 30 if not more classes without a classification and label (all genes or taxa):
To solve this, I would suggest, contrary to what I might have said in the past, we run releases every Monday before a release.
@twhetzel @sabrinatoro let me know what you think!
The text was updated successfully, but these errors were encountered: