From d4448857706c030a328f8c0ae812ae58b2b5c00d Mon Sep 17 00:00:00 2001 From: tsa96 Date: Sun, 31 Dec 2023 14:18:10 +0000 Subject: [PATCH] ci(front-e2e): disable frontend e2e This is barely doing anything right now since we don't have any frontend e2e tests. Since I removed the main page, we can no longer just test that, and without a JWT the dashboard will try to redirect you to Steam, or spit out errors. We could generate logins and stuff relatively easily, but I just don't want to work on it for now. So I'm disabling this task until we do the auth-less stuff, or major new Cypress stuff. --- .github/workflows/test.yml | 72 ++++++++++++++++++++------------------ 1 file changed, 37 insertions(+), 35 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index c0c8ffeeee..6d1d0d8f15 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -135,38 +135,40 @@ jobs: docker compose -f docker-compose.yml -f docker-compose.test.yml run backend-e2e - frontend-e2e: - name: Frontend E2E Tests - runs-on: ubuntu-latest - needs: install-deps - steps: - - uses: actions/checkout@v3 - with: - ref: ${{ github.event.pull_request.head.ref }} - repository: ${{ github.event.pull_request.head.repo.full_name }} - fetch-depth: 0 - submodules: 'true' - - name: Cache node_modules - uses: actions/cache@v3 - with: - path: node_modules - key: modules-${{ github.run_id }} - - name: Check affected - run: - | - if npx nx show projects \ - --affected \ - --base=${{ github.event.pull_request.base.sha }} \ - --head=${{ github.event.pull_request.head.sha }} | - grep -q frontend-e2e - then - echo "affected=true" >> $GITHUB_ENV - else - echo "affected=false" >> $GITHUB_ENV - fi - - name: Run tests in Docker - if: env.affected == 'true' - run: - docker compose - -f docker-compose.yml -f docker-compose.test.yml - run frontend-e2e +# Disabled until we allow using this site without a Steam login +# https://github.com/momentum-mod/website/issues/878 +# frontend-e2e: +# name: Frontend E2E Tests +# runs-on: ubuntu-latest +# needs: install-deps +# steps: +# - uses: actions/checkout@v3 +# with: +# ref: ${{ github.event.pull_request.head.ref }} +# repository: ${{ github.event.pull_request.head.repo.full_name }} +# fetch-depth: 0 +# submodules: 'true' +# - name: Cache node_modules +# uses: actions/cache@v3 +# with: +# path: node_modules +# key: modules-${{ github.run_id }} +# - name: Check affected +# run: +# | +# if npx nx show projects \ +# --affected \ +# --base=${{ github.event.pull_request.base.sha }} \ +# --head=${{ github.event.pull_request.head.sha }} | +# grep -q frontend-e2e +# then +# echo "affected=true" >> $GITHUB_ENV +# else +# echo "affected=false" >> $GITHUB_ENV +# fi +# - name: Run tests in Docker +# if: env.affected == 'true' +# run: +# docker compose +# -f docker-compose.yml -f docker-compose.test.yml +# run frontend-e2e