how to document optional terms in budget equations #1548
klindsay28
started this conversation in
General
Replies: 1 comment
-
Thanks @klindsay28 for this comment. I vote for option 2: document more scenarios. Option 3 will take much more thought and code, whereas option 2 merely requires more comments in the code. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The following text occurs at the end of MOM.F90:
MOM6/src/core/MOM.F90
Lines 3986 to 3997 in 8d80d64
If one runs MOM6 with KPP via CVMix, then the term
KPP_NLtransport_heat
also needs to be included.If one runs MOM6 with
USE_LATERAL_BOUNDARY_DIFFUSION
, then the termT_lbdxy_cont_tendency
also needs to be included.Despite the text in MOM.F90 being worded as "an example 3d heat budget", I get tripped up that the decomposition of
OPOTTEMPTEND
is incomplete for some model configurations. Below are some potential approaches to help avoid that confusion, listed in what I suspect is increasing order of implementation complexity:KPP_NLtransport_heat
inBOUNDARY_FORCING_HEAT_TENDENCY
and includeT_lbdxy_cont_tendency
inOPOTTEMPPMDIFF
(and change 'neutral diffusion' in the description to 'lateral mixing').Thoughts?
(We have the same problem in CESM/POP that some terms in tracer budget decompositions need to be included or not depending on the model configuration. We sidestep the issue by not documenting the decomposition.)
Beta Was this translation helpful? Give feedback.
All reactions