Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start_wg_listener parameters #33

Open
tabinfl opened this issue Jan 2, 2023 · 1 comment
Open

start_wg_listener parameters #33

tabinfl opened this issue Jan 2, 2023 · 1 comment

Comments

@tabinfl
Copy link

tabinfl commented Jan 2, 2023

Describe the bug

start_wg_listener does not accept a host parameter, and requires tun_ip.

This is inconsistent with the other start listener functions, and does not reflect the actual requirements of the underlying gRPC call.

PR incoming.

@tabinfl
Copy link
Author

tabinfl commented Jan 3, 2023

#36 also addresses this, an error is not raised if tun_ip is missing (in either wg listener or wg implant generation), but everything breaks at runtime if it is omitted.

Could do similar on implant generation, that's also done under the hood in the CLI but will break everything if omitted from a wg implant build. Happy to add that to the PR if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant