From fae56465e3ce6c89b01883fc298093c3187ada88 Mon Sep 17 00:00:00 2001
From: Clemens Tolboom <c.g.w.m.tolboom@umcg.nl>
Date: Wed, 22 Nov 2023 08:36:13 +0100
Subject: [PATCH] Test on port and host.

---
 ui/src/views/Profiles.vue            | 41 +++++++++++++++++++++-------
 ui/tests/unit/views/Profiles.spec.ts |  2 +-
 2 files changed, 32 insertions(+), 11 deletions(-)

diff --git a/ui/src/views/Profiles.vue b/ui/src/views/Profiles.vue
index c5941db0d..b4aa30b34 100644
--- a/ui/src/views/Profiles.vue
+++ b/ui/src/views/Profiles.vue
@@ -40,13 +40,20 @@
       </template>
       <template #objectType="objectProps">
         <div
-          v-if="objectProps.data && statusMapping[objectProps.data.status as keyof typeof statusMapping]"
+          v-if="
+            objectProps.data &&
+            statusMapping[objectProps.data.status as keyof typeof statusMapping]
+          "
           class="row"
         >
           <div class="col-6">
             <span
               class="badge"
-              :class="`bg-${statusMapping[objectProps.data.status as keyof typeof statusMapping].color}`"
+              :class="`bg-${
+                statusMapping[
+                  objectProps.data.status as keyof typeof statusMapping
+                ].color
+              }`"
             >
               {{
                 statusMapping[
@@ -60,7 +67,9 @@
               :disabled="true"
               v-if="objectProps.row.name === loadingProfile"
               :text="
-                statusMapping[objectProps.data.status as keyof typeof statusMapping].status === 'OFFLINE'
+                statusMapping[
+                  objectProps.data.status as keyof typeof statusMapping
+                ].status === 'OFFLINE'
                   ? 'Starting'
                   : 'Stopping'
               "
@@ -69,7 +78,11 @@
             <ProfileStatus
               v-else
               :disabled="loading"
-              :text="statusMapping[objectProps.data.status as keyof typeof statusMapping].text"
+              :text="
+                statusMapping[
+                  objectProps.data.status as keyof typeof statusMapping
+                ].text
+              "
               @click.prevent="
                 statusMapping[
                   objectProps.data.status as keyof typeof statusMapping
@@ -77,7 +90,11 @@
                   ? stopProfile(objectProps.row.name)
                   : startProfile(objectProps.row.name)
               "
-              :icon="statusMapping[objectProps.data.status as keyof typeof statusMapping].icon"
+              :icon="
+                statusMapping[
+                  objectProps.data.status as keyof typeof statusMapping
+                ].icon
+              "
             ></ProfileStatus>
           </div>
         </div>
@@ -286,11 +303,15 @@ export default defineComponent({
         return profile.name;
       });
 
-      const portAlreadyUsed = this.profiles.some((prof) => {
-        return prof !== profile && prof.port == profile.port;
-      });
-      if (portAlreadyUsed) {
-        this.errorMessage = `Save failed: port number [${profile.port}] already used.`;
+      const hostPortCombo = `${profile.host}:${profile.port}`;
+
+      const hasDuplicates = this.profiles.some(
+        (prof) =>
+          prof !== profile && `${prof.host}:${prof.port}` === hostPortCombo
+      );
+
+      if (hasDuplicates) {
+        this.errorMessage = `Save failed: [${hostPortCombo}] already used.`;
         return;
       }
 
diff --git a/ui/tests/unit/views/Profiles.spec.ts b/ui/tests/unit/views/Profiles.spec.ts
index 407efce0e..4bea5752b 100644
--- a/ui/tests/unit/views/Profiles.spec.ts
+++ b/ui/tests/unit/views/Profiles.spec.ts
@@ -224,7 +224,7 @@ describe("Profiles", () => {
         wrapper.vm.profiles.unshift(p);
         wrapper.vm.profileToEditIndex = 0;
         wrapper.vm.saveEditedProfile();
-        expect(wrapper.vm.errorMessage).toBe("Save failed: port number [6313] already used.");
+        expect(wrapper.vm.errorMessage).toBe("Save failed: [localhost:6313] already used.");
     });
 
     test("fail to save a unnamed profile", () => {