Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: column.getReferences() returning incorrect column names for ColumnType.REFBACK #4569

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: column.getReferences() returning incorrect column names for ColumnType.REFBACK #4569

wants to merge 2 commits into from

Conversation

svandenhoek
Copy link
Contributor

What are the main changes you did

How to test

  • Evaluate if indeed this method is the preferred way to fix the issue (instead of f.e. changing the output of a REFBACK Query).
  • All tests succeed.

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@svandenhoek svandenhoek marked this pull request as draft December 17, 2024 12:33
@svandenhoek
Copy link
Contributor Author

By changing Column.getReferences() to use - for ColumnType.REFBACK, SQLQuery does the exact opposite and existing tests fail:

ERROR: column gql_Person.uncles.firstName does not exist
Hint: Perhaps you meant to reference the column "gql_Person.uncles-firstName".

So either:

  1. A different function is needed that returns usable column names for usage externally.
  2. Some internal mechanism around REFBACKS needs changing.

@svandenhoek svandenhoek mentioned this pull request Dec 17, 2024
Open
1 task
@mswertz mswertz self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mswertz mswertz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong column name in Column.getReferences() when dealing with composite REFBACK
2 participants
@svandenhoek @mswertz