fix (RDF): composite key objects #4566
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svandenhoek
commented
Dec 16, 2024
Comment on lines
+81
to
+90
| @Test | ||
| void testEncodedValues() { | ||
| assertAll( | ||
| () -> assertEquals("a=1", new PrimaryKey(Map.of("a", "1")).getEncodedValue()), | ||
| () -> assertEquals("a=1&b=2", new PrimaryKey(Map.of("a", "1", "b", "2")).getEncodedValue()), | ||
| () -> | ||
| assertEquals( | ||
| "a=1&b=2&c=3", | ||
| new PrimaryKey(Map.of("a", "1", "b", "2", "c", "3")).getEncodedValue())); | ||
| } |
There was a problem hiding this comment.
@BrendaHijmans Added this check for making sure a composite key with more than 2 keys works correctly. This class is used to generate the full reference IRI here:
The code before this that ends up creating the input for PrimaryKey does not care about the number of composite keys, so if other tests with 2 primary keys work, it should work with more as well:
You can mark this as solved if you feel this answers your concern adequately. Otherwise, let me know.
1 task
Conflicts: backend/molgenis-emx2-rdf/src/test/java/org/molgenis/emx2/rdf/ColumnTypeRdfMapperTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the main changes you did
How to test
Known issues
Column.getReferences()when dealing with composite REFBACK #4564Checklist