You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds functionality to the Pyclients get method to be able to retrieve data through the GraphQL API.
The following things need to be implemented before the PR is ready for review:
create parsing function to convert a table's metadata to a GraphQL query
implement the distinction between CSV and GraphQL API call in get
add columns parameter to get, specifying which columns need to be returned
add expand parameter to expand the query on reference columns to gather all columns from the referenced table
implement query filter on GraphQL query
How to test
explain here what to do to test this (or point to unit tests)
Checklist
updated docs in case of new feature
added/updated tests
added/updated testplan to include a test for this fix, including ref to bug using # notation
YpeZ
changed the title
feat(Pyclient): add support for GraphQL API to 'get' method
feat(pyclient): add support for GraphQL API to 'get' method
Dec 11, 2024
YpeZ
linked an issue
Dec 11, 2024
that may be
closed
by this pull request
In my latest commit I implemented a filter on the columns of the output of get, i.e. get me the values of only these column of the table.
This leads to discrepancies between the results of the GraphQL and CSV API, as the columns of a table from the GraphQL API and the CSV API may differ. In my GraphQL query building I include REFBACKs whereas the CSV API does not.
This and my expectation that the implementation of the query_filter for GraphQL will differ significantly from the CSV one makes me consider separating these methods into a method for each API, as for the user the arguments they fill in for either format will differ significantly.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YpeZ
changed the title
What are the main changes you did
This PR adds functionality to the Pyclients
getmethod to be able to retrieve data through the GraphQL API.The following things need to be implemented before the PR is ready for review:
getcolumnsparameter toget, specifying which columns need to be returnedexpandparameter to expand the query on reference columns to gather all columns from the referenced tableHow to test
Checklist