Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/#3748): v16.0.0 release candidate #599

Merged
merged 44 commits into from
Mar 13, 2024
Merged

Conversation

oderayi
Copy link
Collaborator

@oderayi oderayi commented Feb 6, 2024

No description provided.

oderayi and others added 25 commits February 6, 2024 14:48
chore: quoting service house keeping
* feat(mojaloop/#3768): create dashboard-performance-troubleshooting.json (#601)

* fix: node list regexp shows all the nodes in dashboard-performance-troubleshooting.json (#604)

* feat(iprod-379): updated quoting-service to v15.7.0

* feat(iprod-379): merge conflicts cleaning

* feat(iprod-379): merge conflicts cleaning

---------

Co-authored-by: Muzammil <[email protected]>
chore: update charts for fixing bug #3759
mojaloop/Chart.yaml Outdated Show resolved Hide resolved
@elnyry-sam-k
Copy link
Member

Thanks Steven, two final comments left.

Also, have the linting rules changed, the older format on some TTK config was more readable and now all that seems to have collapsted into a blob of text instead of each config in its own line..

@oderayi oderayi requested a review from elnyry-sam-k March 13, 2024 08:41
@oderayi
Copy link
Collaborator Author

oderayi commented Mar 13, 2024

Thanks Steven, two final comments left.

Also, have the linting rules changed, the older format on some TTK config was more readable and now all that seems to have collapsted into a blob of text instead of each config in its own line..

On the TTK config, there is a known issue with the underlying yaml parser used by updatecli (our automation tool) that causes some multiline strings in yaml to be mangled. We will revisit this issue in the next release. For now, the configs have been manually reformatted.

elnyry-sam-k
elnyry-sam-k previously approved these changes Mar 13, 2024
Copy link
Member

@elnyry-sam-k elnyry-sam-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Steven! Thank you!

elnyry-sam-k
elnyry-sam-k previously approved these changes Mar 13, 2024
Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@oderayi oderayi merged commit 120408c into master Mar 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants