Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#340: Fix hangs at low UNIDIST_MPI_SHARED_OBJECT_STORE_THRESHOLD #380

Merged
merged 4 commits into from
Nov 7, 2023
Merged

FIX-#340: Fix hangs at low UNIDIST_MPI_SHARED_OBJECT_STORE_THRESHOLD #380

merged 4 commits into from
Nov 7, 2023

Conversation

Retribution98
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 .
  • passes black .
  • signed commit with git commit -s
  • Resolves MPI backend hangs when setting UNIDIST_MPI_SHARED_OBJECT_STORE_THRESHOLD to a lower threshold #340
  • tests added and passing
  • module layout described at docs/developer/architecture.rst is up-to-date

@Retribution98 @YarShev
Apply suggestions from code review
390d0b4 
Co-authored-by: Iaroslav Igoshev <[email protected]>
YarShev and others added 2 commits November 7, 2023 12:31
@YarShev
One more fix
2e8e146 
Signed-off-by: Igoshev, Iaroslav <[email protected]>
@Retribution98
Add info_size
a6115de
@YarShev YarShev merged commit f50fc44 into modin-project:master Nov 7, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MPI backend hangs when setting UNIDIST_MPI_SHARED_OBJECT_STORE_THRESHOLD to a lower threshold
2 participants
@Retribution98 @YarShev