-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate and publish dashboard into documentation #505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I believe we discussed running the dashboard generation only on push to release?
- Do we have any mechanism to timeout a dashboard run overall? I'm worried if it was flaky about nontermination to start then maybe we'd need to worry about that again? I don't want to end up with github actions running for... presumably some default timeout?
Well litani didn't work, so I guess we still don't have a sense of how long it'll take in CI
|
In response to your questions:
We are actually getting three different errors. For macOS we get the one below:
I think this is due to the MacOS runner being too slow, basically. The error on Ubuntu 20.04 is:
Because we need to add litani dependencies. |
Okay, that worked (50 minutes). Saving the run here. I am going to apply the final changes now. |
rmc-docs/src/dashboard.md
Outdated
@@ -0,0 +1,11 @@ | |||
# RMC Dashboard | |||
|
|||
The [RMC Dashboard](./dashboard/index.html) purpose is to show the level of support in RMC for all Rust features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: grammar, either "RMC Dashboard's purpose" or "the purpose of..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the new version.
rmc-docs/src/dashboard.md
Outdated
# RMC Dashboard | ||
|
||
The [RMC Dashboard](./dashboard/index.html) purpose is to show the level of support in RMC for all Rust features. | ||
To this end, we extract all examples from the following books: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe more description, like "all Rust code snippet examples from the following general Rust documentation books"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I extended it a bit but would like to extend and review this in a follow-up PR, so opened #509
scripts/setup/ubuntu/install_deps.sh
Outdated
@@ -14,7 +14,9 @@ DEPS=( | |||
g++ | |||
gcc | |||
git | |||
gnuplot # Litani (recommended) dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a line to the README about running install_deps.sh
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed @zhassan-aws advice to put this into its own script. Do you want to use install_deps.sh
in our README like we do in rmc-docs
?
scripts/setup/ubuntu/install_deps.sh
Outdated
@@ -14,7 +14,9 @@ DEPS=( | |||
g++ | |||
gcc | |||
git | |||
gnuplot # Litani (recommended) dependency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to add gnuplot
as a dependency to RMC? It brings in a ton of other packages. Since the Installation section of the tutorial refers to install_deps.sh
, can we perhaps put gnuplot
in a separate install_dashboard_deps.sh
that is only run in CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked this idea so I added it. The script is only run in the workflow when the dashboard is going to be generated.
* Generate and publish dashboard into documentation * Add Litani deps & restrict workflow to 20.04 * Add setuptools * Final edits * Conform with rebase * Install script for litani deps * Add more docs for dashboard * Enable dash run in CI (to be removed) * Include dashboard deps script * Dashboard deps permissions * Uncomment workflow condition * Update README quickstart section * minor fix
* Generate and publish dashboard into documentation * Add Litani deps & restrict workflow to 20.04 * Add setuptools * Final edits * Conform with rebase * Install script for litani deps * Add more docs for dashboard * Enable dash run in CI (to be removed) * Include dashboard deps script * Dashboard deps permissions * Uncomment workflow condition * Update README quickstart section * minor fix
* Generate and publish dashboard into documentation * Add Litani deps & restrict workflow to 20.04 * Add setuptools * Final edits * Conform with rebase * Install script for litani deps * Add more docs for dashboard * Enable dash run in CI (to be removed) * Include dashboard deps script * Dashboard deps permissions * Uncomment workflow condition * Update README quickstart section * minor fix
* Generate and publish dashboard into documentation * Add Litani deps & restrict workflow to 20.04 * Add setuptools * Final edits * Conform with rebase * Install script for litani deps * Add more docs for dashboard * Enable dash run in CI (to be removed) * Include dashboard deps script * Dashboard deps permissions * Uncomment workflow condition * Update README quickstart section * minor fix
Description of changes:
Generates and publishes the dashboard into
rmc-docs
, where we have included a dedicated section and the dashboard itself.Resolved issues:
Resolves #484
Call-outs:
If approved, the dashboard step will be restricted to run in the same way as the publication step.
Testing:
How is this change tested? See the CI run here.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.