Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spotRadius #18

Open
tischi opened this issue Oct 8, 2022 · 2 comments
Open

spotRadius #18

tischi opened this issue Oct 8, 2022 · 2 comments

Comments

@tischi
Copy link

tischi commented Oct 8, 2022

@constantinpape We don't have the spotRadius field yet in the dataset.json here, do we? Could you please add it to the SpotDisplay?

@constantinpape
Copy link
Contributor

Done. I set it to 0.25 now, which sounded reasonable to me in micrometer, but it's easy to change to some other value ofc.

Also note that for now we haven't declared the spotRadius as mandatory in the spec, so the previous version of the dataset.json was also valid. This means that in general you need to take some default value (1?!) if the spotRadius is not given. But if you prefer we could also make spotRadius mandatory.

@tischi
Copy link
Author

tischi commented Oct 8, 2022

I can put 1.0 as default, but I think one SHOULD provide it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants