Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Level current view" #91

Open
tischi opened this issue May 2, 2022 · 3 comments
Open

"Level current view" #91

tischi opened this issue May 2, 2022 · 3 comments

Comments

@tischi
Copy link
Contributor

tischi commented May 2, 2022

@constantinpape

Did you merge the branch with the new "level current view" yet?

image

It is not here...

@constantinpape
Copy link
Contributor

This is waiting on feedback from you since quite a while ago... #89

@constantinpape
Copy link
Contributor

constantinpape commented May 2, 2022

Also note that we decided to just use the view functonality for it and rename it to "anatomical views". See diff in #89 for details.
I will look into fixing the merge conflicts and could then merge it at any time, but please make sure that the "defaultLocation" in there works (we prematurely merged this at some point, which then prevented the whole project from loading)

@constantinpape
Copy link
Contributor

Ok, I went ahead and merged the PR since solving the merge conflicts was a bit more difficult otherwise.
The project can still be opened and there is now "anatomical views->coronal" (which should correspond to the previous "level view") + the default location is in the json (field "defaultLocation").
I haven't checked if any of this works correctly in the viewer, so I am leaving this open for you to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants