Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec-v3, Figure views don't work #6

Open
martinschorb opened this issue Oct 25, 2022 · 7 comments
Open

spec-v3, Figure views don't work #6

martinschorb opened this issue Oct 25, 2022 · 7 comments
Assignees

Comments

@martinschorb
Copy link
Collaborator

Hi,

I cannot get the figure views to work in spec-v3.

@tischi
Copy link
Contributor

tischi commented Oct 27, 2022

I don't know this project at all.

Could you please pick one view for me and let me know how it is expected to look like?

@martinschorb
Copy link
Collaborator Author

martinschorb commented Oct 27, 2022

I just checked the main branch of that project using the v2 viewer, and the "Figure..." views look the same (no useful views).

These bookmarks were manually exported from MoBIE using the Viewer. I then simply added them to the datasets.
Do you have an idea what could be wrong with them?

It could even be that they were generated with v1 "Export bookmark" functionality.
They are all bookmarks, just specifying:

"viewerTransform": {
        "normalizedAffine"
...

Is there an incompatibility here between the old versions?

@martinschorb
Copy link
Collaborator Author

Here are the bookmarks I got from then and I simply added them to the dataset. That was about a year ago.
I am pretty sure that we checked at least a couple to make sure they work.
But they don't seem to work in more recent MoBIE versions.

bookmarks_PAG_ACC_dAPEX2.zip

@martinschorb
Copy link
Collaborator Author

They look different from the v2 version specs. @constantinpape converted the project f28e9fc just after I uploaded.
It looks like something went wrong there...

@martinschorb
Copy link
Collaborator Author

I have no v1 MoBIE viewer, so unfortunately, I cannot reproduce how these bookmarks looked like originally.

@tischi
Copy link
Contributor

tischi commented Oct 27, 2022

ping @constantinpape

@constantinpape
Copy link
Contributor

I have some ideas what's going on here, but it's hard to explain in an issue.
Basically it's because the "position" argument was dropped in the converter (the very early version that went to the spec v1). My guess is that this was wrong and we need to instead translate the view by it. I can try if that actually fixes the views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants