Allow deletion of views via the UI #1193
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1148
This PR allows deletion of views via right clicking in the MoBIE viewer and selecting
Delete View
. Similar to the view saving options, it allows deleting views from the 'current project' (i.e. the dataset.json) or an 'external file' (any view .json saved on the file system). The 'current project' option is currently only implemented for local projects - if you try to use it with a github / s3 project it should throw an error.Let me know if any changes are needed! I tried it out locally with a few example projects, but it would be great if more people could test this out to check everything is working correctly 😄