Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeoutError better represented for Resource Limit Issue #60

Open
morissette opened this issue Mar 17, 2017 · 0 comments
Open

TimeoutError better represented for Resource Limit Issue #60

morissette opened this issue Mar 17, 2017 · 0 comments
Assignees

Comments

@morissette
Copy link

morissette commented Mar 17, 2017

   try:
        deployment.update()
        print "updated deployment {} on {}".format(deployment_name, namespace)
    except K8sExceptions.TimedOutException:
        print "check resource limits for namespace {}".format(namespace)
        return False, receipt
    return True, receipt

If limits is < requests in regards with resources:
A TimeOutException is raised vs a ResourceLimitException

Improvement:
Check resource limits for given namespace prior to making any changes
Raise error if it doesn't make snese to make said change

@sebastienc sebastienc self-assigned this Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants