review addDOMLoadEvent

[mnot]

Make sure that addDOMLoadEvent is still relevant / correct, and plays nicely with jquery, etc.

[yellow1912]

I see this one is still open. I have a different comment on it: I wonder if we should auto run hinclude, in some cases we want to do something first before triggering it. With the current code it is not possible.

The easiest way is to completely remove this line: hinclude.addDOMLoadEvent(function () { hinclude.run(); });

The second way, is that within the run method we can check for some configuration such as var load = this.get_meta("include_load", "custom");

What do you think?

[mnot]

I don't think hInclude should take over the DOM loading infrastructure; there are plenty of libraries out there for that.

[yellow1912]

Actually, what I mean to say is that hinclude should not automatically trigger on domload event the way it is working right now. There are use cases when we want to manually trigger hinclude instead.

[leroy0211]

Seems like that function is being used as constructor.

Maybe refactor it to be like this

function hinclude(){
     // code from addDOMLoadEvent
}
hinclude.prototype = { ... }