Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use org.mmtk.plan.ThirdParty for all rust mmtk builds #71

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Jun 25, 2021

This PR changes all the Rust MMTk builds to use a stub plan (org.plan.ThirdParty) in JikesRVM. I measured the performance for semispace, and found the average is the same as before refactoring. The performance graph is as below (80 invocations, measured benchmark time, comparing this PR with master).

Screen Shot 2021-07-09 at 11 38 12 am

JikesRVM PR: mmtk/jikesrvm#8

@javadamiri
Copy link

What is the status of this PR?
I think this is an essential change before JikesRVM's upstreaming

@qinsoon
Copy link
Member Author

qinsoon commented Jun 30, 2021

What is the status of this PR?
I think this is an essential change before JikesRVM's upstreaming

I can get it ready soon. I think it works fine. I will check performance.

@qinsoon qinsoon marked this pull request as ready for review July 8, 2021 23:43
@qinsoon qinsoon requested a review from javadamiri July 8, 2021 23:44
Copy link

@javadamiri javadamiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants