Fix duplicate chat connection id crash #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusLongmuir
commented
Jul 2, 2024
| @@ -360,7 +360,7 @@ export class Networked3dWebExperienceClient { | |||
| this.networkChat = new ChatNetworkingClient({ | |||
| url: this.config.chatNetworkAddress, | |||
| sessionToken: this.config.sessionToken, | |||
| websocketFactory: (url: string) => new WebSocket(`${url}?id=${this.clientId}`), | |||
There was a problem hiding this comment.
Drive-by cleanup
TheCodeTherapy
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where old/flaky connections that a client has abandoned are still tracked by the server and retry attempts from the client would result in a collision and an error was thrown.
The change in behaviour is to explicitly reject these new incoming attempts in favour of maintaining the old connection until that old connection fails a heartbeat.
What kind of change does your PR introduce? (check at least one)