Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file format readers in VarDriver.cpp have been commented out #73

Open
johnmauff opened this issue Jul 22, 2024 · 1 comment
Open

Comments

@johnmauff
Copy link
Collaborator

Historically Samurai has supported a significant number (26) of different file formats. The current optimized and portable version of Samurai has commented a number of these out. For example, see the VarDriver::read_wwind method in the VarDriver.cpp file. We need to both improve the error check such that Samurai fails if it encounters one of the commented out file format, and we need to port the commented out file format readers to the C++11 standard string manipulation functions

@cenamiller
Copy link
Collaborator

Kamino cloned this issue to NCAR/samurai-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants