Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DiscreteVectorParam nicer if all values are character #179

Open
mb706 opened this issue Jun 16, 2017 · 0 comments
Open

Make DiscreteVectorParam nicer if all values are character #179

mb706 opened this issue Jun 16, 2017 · 0 comments

Comments

@mb706
Copy link
Collaborator

mb706 commented Jun 16, 2017

For most Vector parameters, the values they accept are (atomic) vectors of values in their feasible set. An exception of note is the "discretevector", which uses lists of its feasible values. This is obviously necessary when the discrete values are complicated types. Often enough, however, the possible values of a "discretevector" are all just character(1), in which case it would be very useful if one could use character vectors as values of these discretevector parameters.

I suggest a use.atomic flag (or similar) for makeDiscreteVector[Learner]Param, which

  1. requires all feasible values to be character (or possibly all numeric, all integer etc.).
  2. uses character vectors (or possibly other types) as values instead of lists.

I don't know ParamHelpers internals enough to know what changes 2. would require, one obvious place is constraintsOkParam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant