Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keys should be stored in ParamSet #171

Open
jakob-r opened this issue Mar 27, 2017 · 2 comments
Open

keys should be stored in ParamSet #171

jakob-r opened this issue Mar 27, 2017 · 2 comments

Comments

@jakob-r
Copy link
Member

jakob-r commented Mar 27, 2017

We call makeParamSet(..., keys = c("p", "q")) but we do not store the keys in the parameter set.
They are just used for some kind of feasibility check - which unfortunately can not be done later again because the keys are missing. We can use all.vars later but then we could directly do this and not force the user to pass keys.

@berndbischl
Copy link
Member

i guess this is correct

@jakob-r
Copy link
Member Author

jakob-r commented Mar 29, 2017

What is the preferred option? drop keys or make the argument optional. In case they are not passed us all.vars on the expressions to obtain the keys?
Save them in a slot or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants