Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker manager crashes if unknown containers have tag rc2.live #28

Open
mlilback opened this issue Oct 23, 2017 · 1 comment
Open

docker manager crashes if unknown containers have tag rc2.live #28

mlilback opened this issue Oct 23, 2017 · 1 comment
Labels

Comments

@mlilback
Copy link
Owner

A fatalError happens if there are unknown tags. This will only happen when the docker image info has added/removed containers, which should be incredibly rare.

@mlilback mlilback added the bug label Oct 23, 2017
@mlilback
Copy link
Owner Author

mlilback commented Feb 8, 2018

also happens if you rename a container to keep it around for debugging. The problem is in DockerContainer.init(json:). Exceptions are thrown, and there is no easy way to fix this right now. Probably best to fix when changing to swift serialization. DockerAPIImplementation.parseContainers(json:) needs to use a flatMap and ignore any containters that aren't properly deserialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant