Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithread api call in Wildbench #26

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

jmercat
Copy link
Collaborator

@jmercat jmercat commented Nov 20, 2024

#25

@neginraoof
Copy link
Collaborator

From what I see, the threadpool in eval.py probably could be initialized better to use a higher number of threads:
https://github.com/mlfoundations/dcft_private/blob/70c7f006492028c541e370b620239237e8a8d065/eval/eval.py#L123

Basically max_workers would be 1 if you are testing only one benchmark. Would this fix the issue?

Also, since we are going to use curator soon, maybe it's worth it to just change the backend directly?

@jmercat
Copy link
Collaborator Author

jmercat commented Nov 21, 2024

I think there is a confusion. I did not write that line. I wrote only the threadpool in WildBench that is by default set to 32 workers.

@neginraoof
Copy link
Collaborator

Yeah but my question is that fixing this from eval.py#L123 cannot solve this issue? @jmercat

@jmercat
Copy link
Collaborator Author

jmercat commented Nov 21, 2024

I think those serve different purpose. This one is supposed to parallelize the task including generation (I don't know if it happens or if it works I haven't tested that). Mine only parallelizes API calls which needs a bigger number of workers to be fast and it can handle it because it's not an intensive operation.

@neginraoof
Copy link
Collaborator

i think this one does not parallelize generations, but just parallelizes the evaluation methods. But in any case, i'll merge because with curator we need to change both of these multithreading logics anyways. Thanks!

@neginraoof neginraoof merged commit 639af29 into main Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants