Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead. [9 times] #11

Open
artsi0m opened this issue Feb 11, 2024 · 0 comments

Comments

@artsi0m
Copy link

artsi0m commented Feb 11, 2024

I get following warning when executing eval-buffer on calfw-blocks.el:
src/calfw-blocks/calfw-blocks.el: Warning: ‘loop’ is an obsolete alias (as of 27.1); use ‘cl-loop’ instead. [9 times]
In attempt to silence warning I created following patch:

diff --git a/calfw-blocks.el b/calfw-blocks.el
index dc36a88..3dd180f 100644
--- a/calfw-blocks.el
+++ b/calfw-blocks.el
@@ -178,7 +178,7 @@ VIEW is a symbol of the view type."
      `((eol . ,EOL) (vl . ,(cfw:rt (make-string 1 cfw:fchar-vertical-line) 'cfw:face-grid))
        (hline . ,(cfw:rt
                   (concat
-                   (loop for i from 0 below 2 concat
+                   (cl-loop for i from 0 below 2 concat
                          (concat
                           (make-string 1 (if (= i 0) cfw:fchar-top-left-corner cfw:fchar-top-junction))
                           (make-string num-date-cell-char cfw:fchar-horizontal-line)
@@ -189,7 +189,7 @@ VIEW is a symbol of the view type."
                   'cfw:face-grid))
        (cline . ,(cfw:rt
                   (concat
-                   (loop for i from 0 below 2 concat
+                   (cl-loop for i from 0 below 2 concat
                          (concat
                           (make-string 1 (if (= i 0) cfw:fchar-left-junction cfw:fchar-junction))
                           (make-string num-date-cell-char cfw:fchar-horizontal-line)
@@ -272,7 +272,7 @@ return an alist of rendering parameters."
                                              days content-fun do-weeks)
   "[internal] Insert calendar cells for the linear views."
   (calfw-blocks-render-columns-transpose
-   (loop with cell-width      = (cfw:k 'cell-width param)
+   (cl-loop with cell-width      = (cfw:k 'cell-width param)
          with days            = (or days (cfw:k 'days model))
          with content-fun     = (or content-fun
                                     'cfw:render-event-days-overview-content)
@@ -319,7 +319,7 @@ return an alist of rendering parameters."
   (when periods-stack
     (let ((stack (sort (copy-sequence periods-stack)
                        (lambda (a b) (< (car a) (car b))))))
-      (loop for (row (begin end content props interval)) in stack
+      (cl-loop for (row (begin end content props interval)) in stack
             for beginp = (equal date begin)
             for endp = (equal date end)
             for width = (- cell-width 2)
@@ -350,19 +350,19 @@ DAY-COLUMNS is a list of columns. A column is a list of following form: (DATE (D
          (num-days (length day-columns))
          (first-half (seq-subseq day-columns 0 (/ num-days 2)))
          (second-half (seq-subseq day-columns (/ num-days 2) num-days)))
-    (loop for j from 0 below (/ num-days 2)
+    (cl-loop for j from 0 below (/ num-days 2)
           for day1 = (nth j first-half)
           for day2 = (nth j second-half)
           do
-          (loop with breaked-day-columns =
-                (loop for day-rows in `(,day1 ,day2)
+          (cl-loop with breaked-day-columns =
+                (cl-loop for day-rows in `(,day1 ,day2)
                       for date = (car day-rows)
                       for line = (cddr day-rows)
                       collect
                       (cons date (cfw:render-break-lines
                                   line cell-width cell-height)))
                 with breaked-date-columns =
-                (loop for day-rows in `(,day1 ,day2)
+                (cl-loop for day-rows in `(,day1 ,day2)
                       for date = (car day-rows)
                       for dayname = (aref calendar-day-name-array
                                           (calendar-day-of-week date))
@@ -386,7 +386,7 @@ DAY-COLUMNS is a list of columns. A column is a list of following form: (DATE (D
                                        (length (cdr (nth 1 breaked-date-columns))))
                 for i from 1 to max-height
                 do
-                (loop for k from 0 to 1
+                (cl-loop for k from 0 to 1
                       for day-rows = (nth k breaked-day-columns)
                       for date-rows = (nth k breaked-date-columns)
                       for date = (car day-rows)

I will attach it also as file:
cl.loop.patch

If contributing in this way is not welcome, I might create a fork of this repository and clone it into my emacs dotfiles as a submodule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant