Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does liground send a quit command to engines before quitting? #238

Open
tsoj opened this issue Feb 7, 2022 · 1 comment
Open

Does liground send a quit command to engines before quitting? #238

tsoj opened this issue Feb 7, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@tsoj
Copy link

tsoj commented Feb 7, 2022

When I close LiGround, sometimes engine processes continue to exist and run. I also saw this happening with Nibbler, where the solution was to set quit commands to all engines, before quitting the program itself.

@QueensGambit QueensGambit added the bug Something isn't working label Feb 8, 2022
@QueensGambit
Copy link
Collaborator

Hello @tsoj ,
thank you for the bug report.

There is a quit() method already, but I think it is not called on the program close event right now.

/**
* Tell the engine to quit.
*/
async quit () {
// check for already destroyed stream
if (this.input.destroyed) {
return
}
// wait for ready, then quit & wait for stream close
await this.waitForReady()
this._write('quit')
await waitFor(this.input, 'close')
}

This issue may also be related to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants