diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Changed.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Changed.cs index 4a5a619d1a7e5..e89158982d92c 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Changed.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Changed.cs @@ -7,6 +7,7 @@ namespace System.IO.Tests { + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public class Directory_Changed_Tests : FileSystemWatcherTest { [Fact] @@ -78,7 +79,6 @@ public void FileSystemWatcher_Directory_Changed_SymLink() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_Changed_SynchronizingObject() { string dir = CreateTestDirectory(TestDirectory, "dir"); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Create.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Create.cs index 5771eeeb4afcf..d3777d6aaf6a7 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Create.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Create.cs @@ -6,6 +6,7 @@ namespace System.IO.Tests { + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public class Directory_Create_Tests : FileSystemWatcherTest { [Fact] @@ -31,7 +32,6 @@ public void FileSystemWatcher_Directory_PathNotExists() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_Create() { using (var watcher = new FileSystemWatcher(TestDirectory)) @@ -47,7 +47,6 @@ public void FileSystemWatcher_Directory_Create() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_Create_InNestedDirectory() { string nestedDir = CreateTestDirectory(TestDirectory, "dir1", "nested"); @@ -100,7 +99,6 @@ public void FileSystemWatcher_Directory_Create_SymLink() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_Create_SynchronizingObject() { using (var watcher = new FileSystemWatcher(TestDirectory)) diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Delete.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Delete.cs index e6963b2e14f7f..638eda424c3ed 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Delete.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Delete.cs @@ -7,6 +7,7 @@ namespace System.IO.Tests { + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public class Directory_Delete_Tests : FileSystemWatcherTest { [Fact] @@ -64,7 +65,6 @@ public void FileSystemWatcher_Directory_Delete_DeepDirectoryStructure() } [ConditionalFact(typeof(MountHelper), nameof(MountHelper.CanCreateSymbolicLinks))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_Delete_SymLink() { string dir = CreateTestDirectory(TestDirectory, "dir"); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Move.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Move.cs index 5959660065e50..4e6eb2edafc51 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Move.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.Move.cs @@ -9,6 +9,7 @@ namespace System.IO.Tests { + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public class Directory_Move_Tests : FileSystemWatcherTest { [Fact] @@ -77,7 +78,6 @@ public void Unix_Directory_Move_To_Different_Watched_Directory() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void Directory_Move_From_Unwatched_To_Watched() { DirectoryMove_FromUnwatchedToWatched(WatcherChangeTypes.Created); @@ -86,7 +86,6 @@ public void Directory_Move_From_Unwatched_To_Watched() [Theory] [InlineData(false)] [InlineData(true)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void Directory_Move_In_Nested_Directory(bool includeSubdirectories) { DirectoryMove_NestedDirectory(includeSubdirectories ? WatcherChangeTypes.Renamed : 0, includeSubdirectories); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.NotifyFilter.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.NotifyFilter.cs index 8c43e6b73bf02..cf0677e01634b 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.NotifyFilter.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.Directory.NotifyFilter.cs @@ -9,6 +9,7 @@ namespace System.IO.Tests { + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public partial class Directory_NotifyFilter_Tests : FileSystemWatcherTest { [LibraryImport("advapi32.dll", EntryPoint = "SetNamedSecurityInfoW", SetLastError = true, StringMarshalling = StringMarshalling.Utf16)] @@ -21,7 +22,6 @@ private static partial uint SetSecurityInfoByHandle( string name, uint objectTyp [Theory] [MemberData(nameof(FilterTypes))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_NotifyFilter_Attributes(NotifyFilters filter) { FileSystemWatcherTest.Execute(() => @@ -117,7 +117,6 @@ public void FileSystemWatcher_Directory_NotifyFilter_LastAccessTime(NotifyFilter [Theory] [MemberData(nameof(FilterTypes))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_NotifyFilter_LastWriteTime(NotifyFilters filter) { string dir = CreateTestDirectory(TestDirectory, "dir"); @@ -167,7 +166,6 @@ public void FileSystemWatcher_Directory_NotifyFilter_LastWriteTime_TwoFilters(No [Theory] [MemberData(nameof(FilterTypes))] [PlatformSpecific(TestPlatforms.Windows)] // Uses P/Invokes to set security info - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_NotifyFilter_Security(NotifyFilters filter) { string dir = CreateTestDirectory(TestDirectory, "dir"); @@ -225,7 +223,6 @@ public void FileSystemWatcher_Directory_NotifyFilter_LastWriteAndFileName() /// after each other. /// [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_NotifyFilter_ModifyAndCreate() { string dir = CreateTestDirectory(TestDirectory, "dir"); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Changed.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Changed.cs index e4b3836bbaba8..db3c4043ee1f0 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Changed.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Changed.cs @@ -6,10 +6,10 @@ namespace System.IO.Tests { + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public class File_Changed_Tests : FileSystemWatcherTest { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_File_Changed_LastWrite() { string file = CreateTestFile(TestDirectory, "file"); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Create.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Create.cs index 900bd5795845e..b02f07ecd046c 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Create.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Create.cs @@ -10,6 +10,7 @@ namespace System.IO.Tests { + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public class File_Create_Tests : FileSystemWatcherTest { [Fact] @@ -85,7 +86,6 @@ public void FileSystemWatcher_File_Create_ForcedRestart() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_File_Create_InNestedDirectory() { string nestedDir = CreateTestDirectory(TestDirectory, "dir1", "nested"); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Delete.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Delete.cs index 7aadee8920603..0a3b3ed1a3d10 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Delete.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Delete.cs @@ -8,10 +8,10 @@ namespace System.IO.Tests { + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public class File_Delete_Tests : FileSystemWatcherTest { [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_File_Delete() { using (var watcher = new FileSystemWatcher(TestDirectory)) @@ -28,7 +28,6 @@ public void FileSystemWatcher_File_Delete() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_File_Delete_ForcedRestart() { using (var watcher = new FileSystemWatcher(TestDirectory)) @@ -49,7 +48,6 @@ public void FileSystemWatcher_File_Delete_ForcedRestart() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_File_Delete_InNestedDirectory() { string nestedDir = CreateTestDirectory(TestDirectory, "dir1", "nested"); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs index 342dd64ab78ca..8f17005e55cd7 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs @@ -8,11 +8,11 @@ namespace System.IO.Tests { + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public class File_Move_Tests : FileSystemWatcherTest { [Fact] [PlatformSpecific(TestPlatforms.Windows)] // Expected WatcherChangeTypes are different based on OS - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void Windows_File_Move_To_Same_Directory() { FileMove_SameDirectory(WatcherChangeTypes.Renamed); @@ -127,7 +127,6 @@ public void Unix_File_Move_With_Set_NotifyFilter() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void File_Move_SynchronizingObject() { string dir = CreateTestDirectory(TestDirectory, "dir"); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.NotifyFilter.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.NotifyFilter.cs index dfe5f9fc05154..f4dc8f02eaeb2 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.NotifyFilter.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.NotifyFilter.cs @@ -11,6 +11,7 @@ namespace System.IO.Tests { + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public partial class File_NotifyFilter_Tests : FileSystemWatcherTest { [LibraryImport("advapi32.dll", EntryPoint = "SetNamedSecurityInfoW", SetLastError = true, StringMarshalling = StringMarshalling.Utf16)] @@ -139,7 +140,6 @@ public void FileSystemWatcher_File_NotifyFilter_LastWriteTime(NotifyFilters filt [Theory] [MemberData(nameof(FilterTypes))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_File_NotifyFilter_Size(NotifyFilters filter) { string file = CreateTestFile(TestDirectory, "file"); @@ -194,7 +194,6 @@ public void FileSystemWatcher_File_NotifyFilter_Size_TwoFilters(NotifyFilters fi [Theory] [MemberData(nameof(FilterTypes))] [PlatformSpecific(TestPlatforms.Windows)] // Uses P/Invokes to set security info - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_File_NotifyFilter_Security(NotifyFilters filter) { string file = CreateTestFile(TestDirectory, "file"); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs index 0d471cc987673..07a3e3c24bb91 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.InternalBufferSize.cs @@ -8,6 +8,7 @@ namespace System.IO.Tests { + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public class InternalBufferSizeTests : FileSystemWatcherTest { // FSW works by calling ReadDirectoryChanges asynchronously, processing the changes @@ -74,7 +75,6 @@ public void FileSystemWatcher_InternalBufferSize(bool setToHigherCapacity) [Fact] [PlatformSpecific(TestPlatforms.Windows)] [OuterLoop("A little slow")] - [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_InternalBufferSize_SynchronizingObject() { ManualResetEvent unblockHandler = new ManualResetEvent(false); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs index 9a3f5c907b47a..20ef67a0a6ada 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.SymbolicLink.cs @@ -79,6 +79,7 @@ public void FileSystemWatcher_SymbolicLink_TargetsDirectory_Create() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_SymbolicLink_TargetsDirectory_Create_IncludeSubdirectories() { FileSystemWatcherTest.Execute(() => @@ -112,6 +113,7 @@ public void FileSystemWatcher_SymbolicLink_TargetsDirectory_Create_IncludeSubdir [Fact] [ActiveIssue("https://github.com/dotnet/runtime/issues/70450", TestPlatforms.OSX)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_SymbolicLink_IncludeSubdirectories_DoNotDereferenceChildLink() { // Arrange diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.cs index 9f0dce0d70a47..f2525543ce2ec 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.cs @@ -170,6 +170,7 @@ public void BeginInit_PausesEnableRaisingEvents() [Theory] [InlineData(true)] [InlineData(false)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void EndInit_ResumesPausedEnableRaisingEvents(bool setBeforeBeginInit) { FileSystemWatcherTest.Execute(() => diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.unit.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.unit.cs index 1248a5744c507..215ed94cb0bf7 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.unit.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.unit.cs @@ -363,6 +363,7 @@ public void FileSystemWatcher_OnCreated() [Fact] [PlatformSpecific(TestPlatforms.OSX | TestPlatforms.Windows)] // Casing matters on Linux + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_OnCreatedWithMismatchedCasingGivesExpectedFullPath() { using (var fsw = new FileSystemWatcher(TestDirectory)) @@ -455,6 +456,7 @@ public void FileSystemWatcher_OnRenamed() [Fact] [PlatformSpecific(TestPlatforms.Windows)] // Unix FSW don't trigger on a file rename. + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Windows_OnRenameGivesExpectedFullPath() { string file = CreateTestFile(TestDirectory, "file"); @@ -932,6 +934,7 @@ public void SetAndGetFiltersProperty() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_File_Delete_MultipleFilters() { // Check delete events against multiple filters @@ -956,6 +959,7 @@ public void FileSystemWatcher_File_Delete_MultipleFilters() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_Create_MultipleFilters() { FileSystemWatcherTest.Execute(() => @@ -980,6 +984,7 @@ public void FileSystemWatcher_Directory_Create_MultipleFilters() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_Directory_Create_Filter_Ctor() { FileSystemWatcherTest.Execute(() => @@ -1023,6 +1028,7 @@ public void FileSystemWatcher_Directory_Delete_MultipleFilters() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_File_Create_MultipleFilters() { FileSystemWatcherTest.Execute(() => @@ -1045,6 +1051,7 @@ public void FileSystemWatcher_File_Create_MultipleFilters() } [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_ModifyFiltersConcurrentWithEvents() { FileSystemWatcherTest.Execute(() => @@ -1096,6 +1103,7 @@ public DangerousFileSystemWatcherTests(ITestOutputHelper output) [PlatformSpecific(TestPlatforms.Linux)] // Reads MaxUsersWatches from Linux OS files [OuterLoop("This test will use all available watchers and can cause failures in other concurrent tests or system processes.")] [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/103584", TestPlatforms.Windows)] public void FileSystemWatcher_CreateManyConcurrentWatches() { int maxUserWatches = int.Parse(File.ReadAllText("/proc/sys/fs/inotify/max_user_watches"));